dev/events#56 Allow backend (de)registration changes for sold out price set items, refactor

[larssandergreen]

Overview

This replaces #20252, which I cannot re-open — but it now includes some refactoring and even more clean up of styles.

Currently, when editing price set selections for an event registrant, you cannot add or remove sold out items. This PR makes it possible for backend users to add or remove price set selections that are sold out from registrations. It also ensures that all full selections show (Sold out) text, both on the Register Participant form and the Change Selections and Edit Event Registration forms.

It also fixes some inconsistent fonts, margins, spacing, etc in price sets.

Perhaps most importantly, it refactors some of the very repetitive Quickform code for price sets to hopefully make that a little more maintainable (though there still a lot more that could be done).

Before

If a price set selection is sold out, back-end users can add this selection on Events - Register Event Participant, but if they edit a existing registration they cannot either add or subtract from sold out selections as these are disabled/frozen (except for removing select fields, which was possible). Back-end users may add registrants to sold out selections unintentionally, as there is no warning that selections are sold out on the Register Participant Form. Backend users cannot remove registrants from sold out selections, which should clearly be possible. They cannot override price set limits if required to add participants to sold out selections.

Register Participant: Backend user can register participant for sold out selections, they are unmarked

Change Selections: Participant cannot be added or removed from sold out selections

Front end registration, lots of odd styling

After

Backend users can register and deregister participants for any price set selection. All price set selections that are sold out are now marked as sold out.

Register participant: Sold out selections are now marked

Change Selections: Participant can be added to or removed from all selections.

Front end registration, a little more readable and consistent

I've also removed the italics, font size and weight from sold out items so the form is less busy and more consistent, enclosed the none option in a span to match other radio options, and added the light sold out grey colour to all sold out options (except the select options). I removed the double 'Sold out' for text fields and added the missing 'Sold out' on select options. Added space between frozen checkbox and radios and text. Fixed inconsistent font size and spacing for pre and post field help.

Comments

I've moved the great concatenate fest that was building the labels for price set options into a separate function so it isn't repeated four times. I've also aligned the process for Text fields with the process for all the other types by moving this from the tpl to the Price Field BAO, so it can use the same function rather than implementing the same logic in Smarty. This required a small change that is a bit odd to get the label for the text field to the tpl, introducing an auxiliary form element that holds the label that goes after the text field, since the text field has two labels. This is all working around the unfortunate situation where text fields are both price fields and price options at the same time.

I've removed some now unneeded code that set form rules for selects and some other repeated code.

The warning found in the previous PR by @BettyDolfing and @jaapjansma has been fixed in the refactoring (thanks for testing and sorry to have been unable to respond at the time). I'm unable to reproduce the blank preview issue.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[larssandergreen]

test this please

[larssandergreen]

test this please

[seamuslee001]

Jenkins re test this please

[larssandergreen]

@seamuslee001 Looks like it's still giving the same error.

[seamuslee001]

Jenkins re test this please (investigating)

[larssandergreen]

Thanks @seamuslee001 for whatever you did to get this working.

[larssandergreen]

There was a conflict with #25033 from @kurund. I have changed from if ($opt['label']) to if !empty($opt['label']) per that PR, the remainder of the changes in that PR were already included in this PR.

[civicrm-builder]

Can one of the admins verify this patch?

[larssandergreen]

jenkins test this please

[larssandergreen]

Closing, replaced with #26112