Use array_key_exists to avoid warning on report GroupBy.tpl template

[braders]

Overview

Use array_key_exists to avoid warning on report GroupBy.tpl template.

Before

PHP warnings (notice up until PHP8) were thrown whenever a report with group options was loaded. Undefined array key. As the warnings were happening in a loop this could cause a lot of noise when viewing error logs.

After

This warning is gone (lots still remaining on reports - baby steps)

Technical Details

Tested with and without CIVICRM_SMARTY_DEFAULT_ESCAPE, and on a handful of reports.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This didn't fully work for me and that kind of makes sense to me. If the higher-level element $form.group_bys_freq doesn't exist then you'll still get an error (repeat contributions report is an example).

Could have two ifs, or an && seems to work. Or back to ensuring it exists in php.

[braders]

This didn't fully work for me and that kind of makes sense to me. If the higher-level element $form.group_bys_freq doesn't exist then you'll still get an error (repeat contributions report is an example).

Could have two ifs, or an && seems to work. Or back to ensuring it exists in php.

Good catch, I had not tested a report that had grouping but no group_bys_freq. I think making sure group_bys_freq array always exists is the right approach. It's a bit late now but I'll look at fixing in the next day or so.

[braders]

@demeritcowboy This should be working correctly now.