[NFC] Assert something in unit test #24626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When I wrote this in #24586 it was just to demonstrate the fail. But then when I redid the PR against 5.54 and added the fix, I forgot to update the test to make an assertion of some kind.
Civi has
beStrictAboutTestsThatDoNotTestAnything
set to false in phpunit.xml. I'm not sure if that's intentional but normally such a test would have passed but been flagged as "risky".