Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Assert something in unit test #24626

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

demeritcowboy
Copy link
Contributor

Overview

When I wrote this in #24586 it was just to demonstrate the fail. But then when I redid the PR against 5.54 and added the fix, I forgot to update the test to make an assertion of some kind.

Civi has beStrictAboutTestsThatDoNotTestAnything set to false in phpunit.xml. I'm not sure if that's intentional but normally such a test would have passed but been flagged as "risky".

@civibot
Copy link

civibot bot commented Sep 27, 2022

(Standard links)

@civibot civibot bot added the master label Sep 27, 2022
@eileenmcnaughton eileenmcnaughton merged commit 30479e1 into civicrm:master Sep 27, 2022
@demeritcowboy demeritcowboy deleted the assert-something branch September 27, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants