Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync api & form layer permissions for jobLog #24619

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 26, 2022

Overview

This is a follow up to #24606 - I checked the form permissions for the JobLog form & they differed slightly from the api layer so I synced & removed the checkPermissions(FALSE)

Before

Api for JobLog falls back to default of Administer CiviCRM but form allows contacts with access CiviCRM AND administer CiviCRM system

After

Api tuned to administer CiviCRM system - the access CiviCRM check seems more a form layer thing & not in keeping with other entities

UI unchanged

image

Technical Details

Other superficial cleanup

Comments

@civibot
Copy link

civibot bot commented Sep 26, 2022

(Standard links)

@civibot civibot bot added the master label Sep 26, 2022
@demeritcowboy demeritcowboy merged commit 995aa4a into civicrm:master Sep 26, 2022
@eileenmcnaughton eileenmcnaughton deleted the job_log branch September 26, 2022 23:25
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants