Sync api & form layer permissions for jobLog #24619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a follow up to #24606 - I checked the form permissions for the
JobLog
form & they differed slightly from the api layer so I synced & removed thecheckPermissions(FALSE)
Before
Api for
JobLog
falls back to default ofAdminister CiviCRM
but form allows contacts withaccess CiviCRM
ANDadminister CiviCRM system
After
Api tuned to
administer CiviCRM system
- the access CiviCRM check seems more a form layer thing & not in keeping with other entitiesUI unchanged
Technical Details
Other superficial cleanup
Comments