Return success from cleanup job

[braders]

Overview

Return success from cleanup job.

Before

The function civicrm_api3_job_cleanup had no return. This is very unusual for a API3 action, and is the first such example I have seen in core. All other actions that I have seen return civicrm_api3_create_success (unless there is an error).

After

The cleanup job returns an explicit success, consistent with other API3 actions.

Comments

The lack of return is currently causing a notice trying to access array offset on value of type null in JobManager.php whenever the cleanup is run via a scheduled job. This is because JobManager.php always expects the standard success or error array to be returned from an API3 action.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

thanks @braders - selfishly I'm pleased your summer is over :-) Appreciate the patches