Put back exception during class scanning

[demeritcowboy]

Overview

In #24580 the exception was changed to a log call to avoid problems with test environments. But it can cause infinite loops with some extensions.

Before

On a site with, e.g. the csvimport extension installed, an infinite loop gives out of memory on every page. No error actually gets logged.

After

Error logged, but back to the original problem.

Technical Details

Comments

An intermediate option might be trigger_error() with E_USER_DEPRECATED, but whether that helps the original problem depends on that test environment's config on how it handles php deprecations during tests.

@eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@demeritcowboy the alternative is just to continue & not do either - we know the exception is actively bad & now we know the log is too - so if the goal is not to break people then we can just do neither

[demeritcowboy]

Ok let's do that.

[eileenmcnaughton]

first, do no harm