(dev/core#3865) Fix css for price fields of html type Select with lon… #24598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Has this been tested on mobile? It feels like this could cause issues due to the narrow screen width. Unlike most CiviCRM screens, the event booking pages are likely to frequently be used on mobile devices and so should be fully responsive. |
CRM/Price/BAO/PriceField.php
Outdated
| @@ -520,10 +520,20 @@ public static function addQuickFormElement( | |||
| else { | |||
| $visibility_id = self::getVisibilityOptionID('public'); | |||
| } | |||
|
|
|||
| $class = ''; | |||
| $maxlen = max(array_map('strlen', $selectOption)) | |||
There was a problem hiding this comment.
semicolon missing here
|
For mobile, I expect it would depend on the theme. The test site here probably isn't the best one to look at but it works:
However on desktop backend registration looks a little weird, but no weirder than the regular contact edit page which also overflows. But also probably depends on theme.
|
|
@demeritcowboy
and after and will only affect the drop-down with long labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g labels
Overview
Fix css for price fields of html type Select with long labels
I propose based on the string length of the longest option we should provide the display,so it doesn't look wrapped for some options.
Before
Currently, the option labels are long the display looks something like this
this is on dmaster
After
looks much nicer