dev/core#3826 Fix regression on contribution search tasks in search-kit #24593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching from GET to POST calls (to support greater numbers of ids) the fix required the qfKey to be set in search-kit. However, the selected class name for the qfKey for contribution tasks was wrong - leading to a validation error
|
(Standard links)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#3826 Fix regression on contribution search tasks in search-kit
When switching from GET to POST calls (to support greater numbers of ids) the fix required the qfKey to be set in search-kit. However, the selected class name for the qfKey for contribution tasks was wrong - leading to a validation error
https://lab.civicrm.org/dev/core/-/issues/3826
Before
Contribution search tasks no longer work from search kit
After
They---'re back - did you miss them?
Technical Details
@demeritcowboy this returns it to working for core tasks - which feels like the priority - but I'm not sure what has been happening in the extension space
Comments