Remove another call to deprecated CRM_Contribute_PseudoConstant::contributionStatus

[eileenmcnaughton]

Overview

Remove another call to deprecated contributionStatus

Before

$contributionStatuses = CRM_Contribute_PseudoConstant::contributionStatus(NULL, 'name');

After

  $newContributionStatus = CRM_Core_PseudoConstant::getName('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $newContributionValues['contribution_status_id']);
    $oldContributionStatus = CRM_Core_PseudoConstant::getName('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $oldContributionValues['contribution_status_id']);

Technical Details

This function is only called from two places in the universe so I gave it a bit of a cleanup too.
I have a feeling php might be deprecating pass-by-ref variables after non-reference variables in a future version (not sure about that) - but it was pretty fugly anyway

Comments

Hundreds of tests pass through this code

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Yeah - as I mentioned test cover

api_v3_ContributionTest::testCreateUpdateContributionInValidStatusChange
api error message not as expectedWe expected a failure for contribution create but got a success:
Failed asserting that 'Cannot change contribution status from %1 to %2.' contains "Cannot change contribution status from Completed to Pending.".

[yashodha]

@eileenmcnaughton you might want to squash the commits

[eileenmcnaughton]

@yashodha I think they might be better not squashed - the second commit was just some removal of abbreviations to make the code more readable (& to not set off IDE spell checkers) but it stands alone

[eileenmcnaughton]

thanks @seamuslee001