Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebugSubscriber - Fix activation check #24569

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

totten
Copy link
Member

@totten totten commented Sep 19, 2022

Backport #24554 from 5.54-rc to 5.53-stable.

Note: This issue doesn't specifically merit a patch-release for 5.53.x. However, when doing any other patch-releases on 5.53, this should provide us with better test-suite guidance.

This subscriber only interjects if XDebug is configured with the suitable mode.

To see if the mode is suitable, it consults `ini_get("xdebug.mode")`, but
this is not quite right -- because the mode may be set other ways (eg
`XDEBUG_MODE`). In XDebug 3.1+, you can get the true effective-mode
by calling `xdebug_info`.

See also: https://xdebug.org/docs/all_functions#xdebug_info
@civibot
Copy link

civibot bot commented Sep 19, 2022

(Standard links)

@civibot civibot bot added the 5.53 label Sep 19, 2022
@totten totten merged commit 7eb5629 into civicrm:5.53 Sep 20, 2022
@totten totten deleted the 5.53-xdebug branch September 20, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants