Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable #24563

Conversation

braders
Copy link
Contributor

@braders braders commented Sep 19, 2022

Overview

Remove unused variable.

Before

Unless I'm missing something, I cannot see any reason for this variable to be defined.

  • The variable is not referenced, and is not global.
  • Creating a new instance of CRM_Contact_BAO_Contact should not cause any relevant side-effects.

After

Variable removed.

Comments

Identified through the variable being greyed-out as unused in my IDE of choice.

@civibot
Copy link

civibot bot commented Sep 19, 2022

(Standard links)

@civibot civibot bot added the master label Sep 19, 2022
@eileenmcnaughton
Copy link
Contributor

Agree - the IDE is pretty clear on this too

image

@eileenmcnaughton eileenmcnaughton merged commit 1aa1cc6 into civicrm:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants