dev/core#3838 - Addressee token evaluates middle_name as literal string null

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/3838

aka Restore string "null" handling when processing greetings

Before

1. Create a contact with a blank middle name.
2. Look at the addressee display in the communication prefs section on contact summary: "John null Smith"

After

Better

Technical Details

Previously it used to call DAO::storeValues which does a check for string "null", but the reason it was changed was because it was completely bypassing them. So this restores handling, but converts it to null null.

Comments

I had trouble writing a test for this because it seems to depend a little on the form. It wasn't clear why though, and then I gave up.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Well, at least you tried to write a test. That counts.

[demeritcowboy]

Thanks!