Add unit test & handling for processing from UserJob configuration rather than form submitted values #24510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add unit test & handling for processing from UserJob configuration rather than form submitted values
Before
Processing of imports deeping tied to quickform form set up
After
Starting to move to support the configuration being saved into the
UserJob
table as two arrays'import mappings'
- which is the row by row information of what field each csv column maps to, and potentially other dataentity_configuration
- this isn't covered in this PR but will hold the stuff that relates to the entity rather than the rowsTechnical Details
The import flow only supports limited config at the moment because of quickform challenges - this starts to add the support for config-based imports - where the config is stored in the
UserJob
rather than being tightly tied to the form.When the import cleanup started the config was passed around in a whole lot of crazy ways. It has been consolidated to the
submitted_values
array which is stored in the user job but the next step in the evolution is for the form layer to transform the config to a sensible format & save it like that rather than drive everything from what the form supportsComments