Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test & handling for processing from UserJob configuration rather than form submitted values #24510

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 14, 2022

Overview

Add unit test & handling for processing from UserJob configuration rather than form submitted values

Before

Processing of imports deeping tied to quickform form set up

After

Starting to move to support the configuration being saved into the UserJob table as two arrays

'import mappings' - which is the row by row information of what field each csv column maps to, and potentially other data
entity_configuration - this isn't covered in this PR but will hold the stuff that relates to the entity rather than the rows

Technical Details

The import flow only supports limited config at the moment because of quickform challenges - this starts to add the support for config-based imports - where the config is stored in the UserJob rather than being tightly tied to the form.

When the import cleanup started the config was passed around in a whole lot of crazy ways. It has been consolidated to the submitted_values array which is stored in the user job but the next step in the evolution is for the form layer to transform the config to a sensible format & save it like that rather than drive everything from what the form supports

Comments

@civibot
Copy link

civibot bot commented Sep 14, 2022

(Standard links)

@colemanw
Copy link
Member

Ok test cover looks good

@colemanw colemanw merged commit 2a534f6 into civicrm:master Sep 14, 2022
@colemanw colemanw deleted the import_default branch September 14, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants