report clean up templates

[yashodha]

Overview

report clean up templates

Before

no need to have tpl

After

goes away!

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Interesting. So the form code automatically defaults to the generic tpl if a specific one is missing?

[demeritcowboy]

Yeah it's a very strange OO-but-not-OO pattern. In normal OO, Report_Form::getTemplateFileName would just return 'Form.tpl', and then if you need an override you'd override getTemplateFileName. For some reason this has procedural code inside the Report_Form::getTemplateFileName to simulate the reverse of that override mechanism.