Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up code simplification - no need to map 'Individual' to 'Individual' #24473

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Follow up code simplification - no need to map 'Individual' to 'Individual'

Before

This function used to help us map a silly constant to a useful ContactType.name - now they are both the same so it's a whole lotta nothing

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented Sep 6, 2022

(Standard links)

@colemanw
Copy link
Member

colemanw commented Sep 6, 2022

Yea, I can see the disadvantage of making up new names for things for no other reason than creating extra constants and mapping functions.

@eileenmcnaughton eileenmcnaughton merged commit 5b60185 into civicrm:master Sep 7, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_const branch September 7, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants