Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF] Standardise validation of mapped fields in imports, fix over-zealous requirements when matching on trxn_id, invoice_id for update #24433

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 1, 2022

Overview

[REF] Standardise validation of mapped fields in imports, fix excessive required fields when matching on trxn_id, invoice_id`

Before

Validattion is still happening in multiple places & each is a bit different

Importing contributions with 'update existing' + trxn_id unnecessarily requires create fields like total_amount & financial type

After

Single place which processes an and/or array - form starts to call the parser layer

Possible to import with trxn_id and do an update without all create fields

Technical Details

This has new test cover for the Contribution import, including the trxn_id situation described and substantial test cover in CRM_Contact_Import_Parser_ContactTest - in particular testValidation

Comments

@civibot
Copy link

civibot bot commented Sep 1, 2022

(Standard links)

@civibot civibot bot added the master label Sep 1, 2022
@eileenmcnaughton eileenmcnaughton force-pushed the required_checker branch 2 times, most recently from 0199178 to bfabad9 Compare September 1, 2022 13:09
@eileenmcnaughton eileenmcnaughton changed the title [REF] Standardise validation of mapped fields in imports [REF] Standardise validation of mapped fields in imports, fix over-zealous requirements when matching on trxn_id, invoice_id for update Sep 1, 2022
@eileenmcnaughton eileenmcnaughton changed the title [REF] Standardise validation of mapped fields in imports, fix over-zealous requirements when matching on trxn_id, invoice_id for update [wip] [REF] Standardise validation of mapped fields in imports, fix over-zealous requirements when matching on trxn_id, invoice_id for update Sep 1, 2022
@eileenmcnaughton eileenmcnaughton changed the title [wip] [REF] Standardise validation of mapped fields in imports, fix over-zealous requirements when matching on trxn_id, invoice_id for update REF] Standardise validation of mapped fields in imports, fix over-zealous requirements when matching on trxn_id, invoice_id for update Sep 1, 2022
@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 22a3e45 into civicrm:master Sep 2, 2022
@eileenmcnaughton eileenmcnaughton deleted the required_checker branch September 2, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants