Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - basic support for creating event participant #24420

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

colemanw
Copy link
Member

Overview

This is pretty basic, but it's a start, and checks a box on https://lab.civicrm.org/dev/core/-/issues/3761

Before

No Afform support for Events.

After

Basic support for adding a participant (unpaid).

Comments

Todo: Payment processor support.
Todo: Conditional custom fields (currently all participant custom fields are available even if they don't apply).
Todo: I think we need some kind of "workflow" mechanism in Form Builder to support stuff like waiting lists, provisional participants (requiring admin approval), and pending payments.

@civibot
Copy link

civibot bot commented Aug 31, 2022

(Standard links)

@civibot civibot bot added the master label Aug 31, 2022
@eileenmcnaughton
Copy link
Contributor

test this please

@colemanw
Copy link
Member Author

retest this please

@wmortada
Copy link
Contributor

  • General standards
    • (r-explain) PASS
    • (r-user) PASS: Fairly obvious how to add a participant to a form. Works as a user would expect.
    • (r-doc) PASS : I don't think documentation is needed at this stage. It's pretty straightforward.
    • (r-run) PASS: Created form with event participant field. Tested form submission. Participant was added to event. Note that the registered date and participant role were blank for the registered participants. See below for screenshots.
  • Developer standards

image

image

Suggestions for further improvement:

  • The registered date should by default be set to the current date and time
  • The participant role should by default be set to 'attendee'

@colemanw
Copy link
Member Author

Thanks for the review @wmortada - reviewing PRs is extremely helpful to the project! ⭐ ⭐ ⭐

I'll work on adding those default values, I agree they would be beneficial.

@colemanw colemanw merged commit 898ce3f into civicrm:master Sep 19, 2022
@colemanw colemanw deleted the afformParticipant branch September 19, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants