REF Code cleanup for event configuration extracted from advancedevents extension #24418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
commented
Aug 30, 2022
| /** | ||
| * @return int | ||
| */ | ||
| protected function getEventId() { |
There was a problem hiding this comment.
Add a "getter" function so we don't have to access class properties directly and it is clearer that $this->_id = event ID.
mattwire
commented
Aug 30, 2022
| @@ -155,7 +161,7 @@ public function postProcess() { | |||
| CRM_Utils_System::redirect(CRM_Utils_System::url($url, $urlParams)); | |||
| } | |||
| else { | |||
| CRM_Core_Error::statusBounce("Could not find Event ID"); | |||
| CRM_Core_Error::statusBounce(ts('Could not find Event ID')); | |||
There was a problem hiding this comment.
This is shown to the user - make it translateable
2c7164e to
5e1070c
Compare
mattwire
commented
Aug 30, 2022
| @@ -94,22 +94,22 @@ | |||
| <ul class="panel" id="panel_participants_{$row.id}"> | |||
| {if $findParticipants.statusCounted} | |||
| <li> | |||
| <a class="action-item crm-hover-button" href="{crmURL p='civicrm/event/search' | |||
| <a title="{ts}Counted Participants{/ts}" class="action-item crm-hover-button" href="{crmURL p='civicrm/event/search' | |||
There was a problem hiding this comment.
Appears when you hover over the link
|
This mergeable just a style issue in the comment header. |
5e1070c to
f257268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The advanced events currently overrides some core files. I'm slowly trying to remove that requirement.
This PR is a collection of a few small code cleanups that I made in the extension and should be in core.
Before
Less code cleanups
After
More code cleanups
Technical Details
Comments