Remove unreachable code #24411
Merged
Remove unreachable code #24411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Aug 29, 2022
| @@ -577,21 +577,6 @@ private function deprecatedFormatParams($params, &$values, $create = FALSE): voi | |||
| } | |||
| $values['pledge_id'] = $params['pledge_id']; | |||
| } | |||
| else { | |||
| // check if there are any pledge related to this contact, with payments pending or in progress | |||
| require_once 'CRM/Pledge/BAO/Pledge.php'; | |||
There was a problem hiding this comment.
Wow, require_once, that's vintage.
|
unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unreachable code
Before
Code line is in theory reached if
params['pledge_id']isset - but empty - however - it doesn't get to this line if it is (well arguably 0 - but that would be some dark magic that is entirely accidental)https://github.com/greenpeace-cee/civicrm-core/blob/717cda3dadfc9e2bf1e643cfe086e56a276c335c/CRM/Contribute/Import/Parser/Contribution.php#L335-L340
After
poof
Technical Details
Comments