Switch Contact import to use new v4 dedupe lookup #24401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
41d4d71 to
d5920b1
Compare
00aae2c to
03d315d
Compare
03d315d to
d02174b
Compare
colemanw
reviewed
Aug 29, 2022
| protected function getPossibleContactMatch(array $params, ?int $extIDMatch, ?int $dedupeRuleID): ?int { | ||
| $checkParams = ['check_permissions' => FALSE, 'match' => $params, 'dedupe_rule_id' => $dedupeRuleID]; | ||
| $possibleMatches = civicrm_api3('Contact', 'duplicatecheck', $checkParams); | ||
| protected function getPossibleContactMatch(array $params, ?int $extIDMatch, $dedupeRuleID): ?int { |
There was a problem hiding this comment.
Ditto to my comment on the contribution PR
|
Code looks good as does test cover. MOP. |
|
Unrelated fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Switch Contact import to use new v4 dedupe lookup
Before
Legacy method used
After
Switches to use the new api method #24384
Technical Details
I focussed on the contact import first as it has excellent test cover - but I'll try the Contribution one with this next
Comments