Fix import classes to call runAllInteractive()
rather than runAllViaWeb
(which in practice currently just calls runAllViaWeb
)
#24396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix import classes to call
runAllInteractive
Before
Import classes call
runAllViaWeb
After
Import classes call
runAllInteractive
Technical Details
This is a no-change PR at the moment as it will still call
runAsWeb
unless the not-yet-viable setting to drive it to the background is used - and we have a gazzillion tests that go through that path.However, this requires some fixes to instantiate the queue more correctly & stop between-test-leakage on the queue singleton (as was hit by the test with the minor doc-block edit)
Comments
@totten this doesn't address the queue runner screen - but I think with this that is the remaining challenge