Add unique index to DedupeRuleGroup.name field #24385
Conversation
|
(Standard links)
|
9135b37 to
a1c8007
Compare
|
All failures were due to test setup creating duplicate rule names. Fixed. |
| */ | ||
| public static function alterDedupeRuleGroupName(CRM_Queue_TaskContext $ctx) { | ||
| CRM_Core_DAO::executeQuery("ALTER TABLE `civicrm_dedupe_rule_group` CHANGE COLUMN `name` `name` varchar(255) COMMENT 'Unique name of rule group'", [], TRUE, NULL, FALSE, FALSE); | ||
| CRM_Core_DAO::executeQuery("UPDATE `civicrm_dedupe_rule_group` g1, `civicrm_dedupe_rule_group` g2 SET g1.name = CONCAT(g1.name, '_', g1.id) WHERE g1.name = g2.name AND g1.id > g2.id", [], TRUE, NULL, FALSE, FALSE); |
There was a problem hiding this comment.
I think you need to reverse the order of these two statements
There was a problem hiding this comment.
@eileenmcnaughton why? The first one just makes the column longer, which makes room for the suffix appended in the 2nd statement.
There was a problem hiding this comment.
Also I think the id > will be safe in practice - but we don't want to rename anything that is_reserved as the name has meaning then
There was a problem hiding this comment.
Actually no - the issue is you aren't creating the indexes - CRM_Core_BAO_SchemaHandler::createIndexes('civicrm_dedupe_rule_group', ['name']);
There was a problem hiding this comment.
hmm - maybe you are but not here...
| @@ -39,6 +39,8 @@ public function setPreUpgradeMessage(&$preUpgradeMessage, $rev, $currentVer = NU | |||
| public function upgrade_5_54_alpha1($rev): void { | |||
| $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev); | |||
| $this->addTask('Add "created_id" column to "civicrm_participant"', 'addCreatedIDColumnToParticipant'); | |||
| $this->addTask('Increase field length of civicrm_dedupe_rule_group.name', 'alterDedupeRuleGroupName'); | |||
| $this->addTask('Add index civicrm_dedupe_rule_group.UI_name', 'addIndex', 'civicrm_dedupe_rule_group', 'name', 'UI'); | |||
|
OK - I've been my own ruber duck - all good, merging |
|
I have no idea what that means, but thanks for merging :) |
|
@colemanw I believe this was in reference to this https://rubberduckdebugging.com/ but Eileen suggesting she was playing the role of the duck as well |
|
quack |
Overview
Ensures DedupeRuleGroup.name field is always unique by adding a db constraint.
Before
Uniqueness was sorta ensured at the form layer.
After
Centralized logic from #22570 plus a unique constraint ensures that it's always unique. Form layer creativity removed.
Comments
Yea... there's kind of no point having a "name" field at all if we don't enforce uniqueness.