Unused functions in CRM_Upgrade_Form

[demeritcowboy]

Overview

They can't be used because they contain calls to nonexistent functions. It's easy to see:

cv ev "(new CRM_Upgrade_Form())->getTemplateFileName();"
Error: Call to undefined method CRM_Upgrade_Form::getTemplateMessage() in CRM_Upgrade_Form->getTemplateFileName() (line 238 of ...\CRM\Upgrade\Form.php).

cv ev "(new CRM_Upgrade_Form())->postProcess();"
Error: Call to undefined method CRM_Upgrade_Form::upgrade() in CRM_Upgrade_Form->postProcess() (line 244 of ...\CRM\Upgrade\Form.php).

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

But it's called upgrade form. There must be a template! And a submit button! 🙃

Anyway, nice catch. Agree these functions aren't usable.

I've wondered before about renaming CRM_Upgrade_Form to reflect the fact that it's not, well, a form. I was concerned about breaking external calls (eg universe/ext/*/CRM/*/Upgrader/Base.php), but we could probably leave a class_alias() behind.

[demeritcowboy]

You could revert this commit: civicrm/civicrm-svn@4fc48c7

[colemanw]

Wow, CiviCRM was so much simpler back then. Imagine having such green pastures to work in today.