[REF]dev/core#2517 Remove tests from core test suites relating to mem… #24342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bership cancellation process and update extension unit tests to cover for gaps in testing
|
(Standard links)
|
seamuslee001
commented
Aug 22, 2022
| $membership = $this->callAPISuccessGetSingle('Membership', ['contact_id' => $this->_contactID]); | ||
|
|
||
| //Assert membership status overrides when the contribution cancelled. | ||
| $this->assertEquals(TRUE, $membership['is_override']); |
There was a problem hiding this comment.
@eileenmcnaughton this seemed to be the only assertion that this test was providing that the extensions ' test CancelFromContributionForm wasn't
seamuslee001
commented
Aug 22, 2022
| $form->buildForm(); | ||
| $form->postProcess(); | ||
|
|
||
| $this->callAPISuccessGetSingle('Activity', [ |
There was a problem hiding this comment.
Likewise this seemed to be the only part of this test that was not being checked by the same extension unit test @eileenmcnaughton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bership cancellation process and update extension unit tests to cover for gaps in testing
Overview
@eileenmcnaughton this should get rid of the other two found in #22686
Before
Core test suites have tests that depend on having the contributecancelactions extension installed
After
Core test suite doesn't rely on it anymore