Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email notices on email edit block #24332

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 21, 2022

Overview

Fix email notices on email edit block

Before

On a contact with no user ID
image

After

image

Technical Details

This moves logic from CRM_Contact_Form_Edit_Email::buildQuickForm that is only used by the Contact_Edit up one step to CRM_Contact_Form_Location::buildQuickForm.

In a separate (merged) PR I fixed the other core place that calls it (the domain form) to ... not call CRM_Contact_Form_Location::buildQuickForm because it is unnecessarily complicate for it's use.

A universe search only finds one non-core call to this function & the form does not definte contactId so it might get an e-notice but nothing worse

image

Comments

@civibot
Copy link

civibot bot commented Aug 21, 2022

(Standard links)

@civibot civibot bot added the master label Aug 21, 2022
@eileenmcnaughton
Copy link
Contributor Author

Note if #24333 is merged then change to Domain form not required

@colemanw colemanw merged commit aa06c48 into civicrm:master Sep 9, 2022
@colemanw colemanw deleted the smarty_sig_html branch September 9, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants