Fix email notices on email edit block #24332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix email notices on email edit block
Before
On a contact with no user ID
After
Technical Details
This moves logic from
CRM_Contact_Form_Edit_Email::buildQuickForm
that is only used by theContact_Edit
up one step toCRM_Contact_Form_Location::buildQuickForm
.In a separate (merged) PR I fixed the other core place that calls it (the domain form) to ... not call
CRM_Contact_Form_Location::buildQuickForm
because it is unnecessarily complicate for it's use.A universe search only finds one non-core call to this function & the form does not definte
contactId
so it might get an e-notice but nothing worseComments