Clean up another cache usage to use metadata #24298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Clean up another cache usage to use metadata
Before
Function uses its own special version of a cache with a php static front end
After
Cache uses 'metadata' cache which has the same config & it otherwise used for option values
Technical Details
This is just standardisation - I didn't identify it during performance testing - but ideally we would have a consistent pattern. I think I might hit some of those
fresh
param calls in the first test run thoughComments