Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up another cache usage to use metadata #24298

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Clean up another cache usage to use metadata

Before

Function uses its own special version of a cache with a php static front end

After

Cache uses 'metadata' cache which has the same config & it otherwise used for option values

Technical Details

This is just standardisation - I didn't identify it during performance testing - but ideally we would have a consistent pattern. I think I might hit some of those fresh param calls in the first test run though

Comments

@civibot
Copy link

civibot bot commented Aug 18, 2022

(Standard links)

@civibot civibot bot added the master label Aug 18, 2022
@eileenmcnaughton eileenmcnaughton force-pushed the cache_odd branch 2 times, most recently from ca5e56b to 34421ee Compare August 19, 2022 09:30
@seamuslee001
Copy link
Contributor

This seems ok to me

@seamuslee001 seamuslee001 merged commit 1d4e70a into civicrm:master Aug 22, 2022
@seamuslee001 seamuslee001 deleted the cache_odd branch August 22, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants