Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Support form filters for relationships #24293

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 18, 2022

Overview

Makes it possible to filter related contacts by relationship fields.

Ref https://lab.civicrm.org/dev/core/-/issues/3468

Before

  1. Create a search for a contact and a related contact
  2. Create a search form
  3. You can add filter fields for each contact, but not the relationship itself

After

image

@civibot civibot bot added the master label Aug 18, 2022
@civibot
Copy link

civibot bot commented Aug 18, 2022

(Standard links)

@colemanw colemanw changed the title Relationship filters SearchKit - Support form filters for relationships Aug 18, 2022
@kurund
Copy link
Contributor

kurund commented Aug 19, 2022

@colemanw

Looks good on the editor and now we can select relationship fields.

Screenshot from 2022-08-19 11-02-51

However, on search relationship fields are not displayed.
Screenshot from 2022-08-19 11-07-00

@colemanw
Copy link
Member Author

colemanw commented Aug 19, 2022

@kurund - adding columns to a search display is a separate configuration and doesn't have to do with filters.
Oh, I see what you mean, the filter fields are missing in your second screenshot. I thought I fixed that but let me double-check.
If you applied this patch locally, did you clear caches?

@colemanw
Copy link
Member Author

@kurund I just tried again and the filter fields are showing up for me. Try clearing caches.

@kurund
Copy link
Contributor

kurund commented Aug 19, 2022

@colemanw

Weird now it's working. Might be a caching issue or my mistake with applying the patch.

Good to merge.

@colemanw colemanw merged commit d41a717 into civicrm:master Aug 19, 2022
@colemanw colemanw deleted the relationshipFilters branch August 19, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants