Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer - Remove unused functions (isErrorInCustomData, getSubtypes, validateCustomField) #24280

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 16, 2022

Overview

Remove function only called from unittest

Before

image

With that removed we see the next one is not used either
image

ditto getSubTypes

image

After

poof

Technical Details

We stopped using this during the re-write. I checked universe & nothing else calls it - although civihr has a function of the same name

Comments

@civibot
Copy link

civibot bot commented Aug 16, 2022

(Standard links)

@civibot civibot bot added the master label Aug 16, 2022
@totten totten changed the title Remove function only called from unittest Importer - Remove function isErrorInCustomData() (only called from unit-test) Aug 16, 2022
@totten totten changed the title Importer - Remove function isErrorInCustomData() (only called from unit-test) Importer - Remove unused functions (isErrorInCustomData, getSubtypes, validateCustomField) Aug 16, 2022
@totten
Copy link
Member

totten commented Aug 16, 2022

Agree these appear to be unused. MOP.

@eileenmcnaughton eileenmcnaughton merged commit feb3bed into civicrm:master Aug 17, 2022
@eileenmcnaughton eileenmcnaughton deleted the cust_err branch August 17, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants