Remove last usage of _fields
from Import_Parser
#24273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove last usage of _fields
Before
In just this one place we still use the old metadata
After
Functionality is unchanged - location field loads for these fields
and the function returns the same array - which is a collection of the fields with
hasLocation
= trueTechnical Details
Over the course of the code tidy up we stopped using the complicated
_fields
construct which entails a whole lot ofField
objects & switched to using the metadata array - however we are still building if for this one placeComments
In fact the motivation for clearing this up is that there are some incorrect pseudoconstant refs in the contribution code & I was trying to purge incorrect refs to
contributionStatus
- however, the code in question can be removed rather than fixed & this change plus a couple of other removal PRs will allow that semi-sub-system to be ripped out so we can stop maintaining it