Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last usage of _fields from Import_Parser #24273

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 15, 2022

Overview

Remove last usage of _fields

Before

In just this one place we still use the old metadata

After

Functionality is unchanged - location field loads for these fields
image

and the function returns the same array - which is a collection of the fields with hasLocation = true
image

Technical Details

Over the course of the code tidy up we stopped using the complicated _fields construct which entails a whole lot of Field objects & switched to using the metadata array - however we are still building if for this one place

Comments

In fact the motivation for clearing this up is that there are some incorrect pseudoconstant refs in the contribution code & I was trying to purge incorrect refs to contributionStatus - however, the code in question can be removed rather than fixed & this change plus a couple of other removal PRs will allow that semi-sub-system to be ripped out so we can stop maintaining it

@civibot
Copy link

civibot bot commented Aug 15, 2022

(Standard links)

@civibot civibot bot added the master label Aug 15, 2022
@eileenmcnaughton eileenmcnaughton changed the title Remove last usage of _fields Remove last usage of _fields from Import_Parser Aug 15, 2022
@seamuslee001
Copy link
Contributor

@eileenmcnaughton can you rebase

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 done

@colemanw colemanw merged commit 8729e57 into civicrm:master Aug 16, 2022
@colemanw colemanw deleted the imp_has_loc branch August 16, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants