Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish consolidating DataSource.tpl across non-contact imports #24267

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Finish consolidating DataSource.tpl

Before

Most imports use a shared DataSource.tpl, Custom data imports are an outlier

image

After

The same Datasource.tpl is used for all imports except Contact (which supports sql query datasources, unlike the others, although this should also be consolidated)

UI should be unchanged
image

Technical Details

At this point the only differences in the tpls are superficial - white space, wording tweaks, html markup

Comments

@civibot
Copy link

civibot bot commented Aug 15, 2022

(Standard links)

@civibot civibot bot added the master label Aug 15, 2022
@eileenmcnaughton eileenmcnaughton changed the title Finish consolidating DataSource.tpl Finish consolidating DataSource.tpl across non-contact imports Aug 15, 2022
@colemanw colemanw merged commit b42e211 into civicrm:master Aug 22, 2022
@colemanw colemanw deleted the datasourcetpl branch August 22, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants