SearchKit - Add contacts to mailing group in batches #24254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the "Email - schedule/send via CiviMail" action, this switches to using the batch runner for adding contacts to the mailing group instead of doing it all at once via chaining. This prevents timeouts when creating very large mailings > 500 contacts.
|
(Standard links)
|
|
@andyburnsco this may solve the problem you had when testing #24186 |
|
As a administrator, it took 3min to create a hidden group of 933 recipients out of 1091 contacts from Search Kit. It seems there is underlying performance issues. There are typical use cases of several thousands of contacts and up to 160K contacts in one org's case. Replicating the same search results in advanced search, it took 1min and 10s as a benchmark. The test is from clicking the email action to the full CiviMail page load. The improvement definitely passes, by keeping the user informed that it is working and building the "list". Probably a "work towards" kind of enhancement. |
|
Thanks for testing @andyburnsco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes potential problems when creating large CiviMail mailing groups via SearchKit (for the "Email - schedule/send via CiviMail" action).
Before
No batching.
After
Uses the batch runner for adding contacts to the mailing group instead of doing it all at once via chaining.
Technical Details
This prevents timeouts when creating very large mailings > 500 contacts.
Comments
This may fix the problems noted in #24186