Move a little code from legacy function loadRelatedObjects to the calling functions

[eileenmcnaughton]

Overview

loadRelatedObjects is a function we have been trying to decommission since the GFC. I'm pretty close to removing the call from the invoice task (which would leave two) but it interacts with _component in weird ways - moving that interaction out of loadRelatedObjects & into the three places that call it creates opportunities for futher code cleanup

Before

The chunk of code that sets _component based on the input is in loadRelatedObjects

After

It is moved to the three calling functions. Two out of the three already call find() so I moved that line to the one that doesn't (or at least on a quick skim didn't appear to - I can look at the functions separately in more depth as we remove their shared dependencies

Technical Details

@mattwire - another baby step - once we get rid of loadRelatedObjects out of the Invoice task it will just remain in transitioncomponents (itself on the hit list) and sendConfirmation

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).