Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import-code-cleanup] Fold call to deprecated function back into calling function #24188

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fold call to deprecated function back into calling function

Before

Call to external deprecated function

After

Code moved into the newly-tested calling function - making it easier to fully dismantle

Technical Details

There is still one more call to the deprecated function - which I will move in a separate PR.

This function was already returning the results on the called function so the only thing I did other than copy & paste was made $params & $contactValues equivalent

Comments

Given the apiv2 deprecated function caused some confusion lets fully rid ourselves of it

@civibot
Copy link

civibot bot commented Aug 9, 2022

(Standard links)

@civibot civibot bot added the master label Aug 9, 2022
@eileenmcnaughton eileenmcnaughton changed the title Fold call to deprecated function back into calling function [Import-code-cleanup] Fold call to deprecated function back into calling function Aug 10, 2022
@colemanw colemanw merged commit 4a20363 into civicrm:master Aug 10, 2022
@colemanw colemanw deleted the import branch August 10, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants