[Import-code-cleanup] Fold call to deprecated function back into calling function #24188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fold call to deprecated function back into calling function
Before
Call to external deprecated function
After
Code moved into the newly-tested calling function - making it easier to fully dismantle
Technical Details
There is still one more call to the deprecated function - which I will move in a separate PR.
This function was already returning the results on the called function so the only thing I did other than copy & paste was made
$params
&$contactValues
equivalentComments
Given the apiv2 deprecated function caused some confusion lets fully rid ourselves of it