-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message Templates - Allow rendering & previewing of translated messages #24174
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
09f31d4
APIv4 - Declare option `$translationMode` (for DAOGetAction)
totten 9048f45
APIv4 - Implement option` $translationMode` via TranslationGetWrapper
totten f61325e
(REF) Move test for `$translationMode` to its own class
totten c17f575
APIv4 - Add generic 'language', 'translationLanguage' to all APIs
eileenmcnaughton 5ea3ea0
Translations - if a message_template has been translated then get/ren…
eileenmcnaughton 6a02902
Translation BAO - Minor strictness cleanups
eileenmcnaughton 01b6270
Pass language into msg_admin api calls
eileenmcnaughton afedf21
(Update) Translations - if a message_template has been translated the…
totten 0fa49e7
MessageTemplateTest - Rearrange with data-provider. Add more tests.
totten 669dcbf
Fix UI bug
eileenmcnaughton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
<?php | ||
|
||
/** | ||
* Wrapper to swap in translated text. | ||
*/ | ||
class CRM_Core_BAO_TranslateGetWrapper { | ||
|
||
protected $fields; | ||
protected $translatedLanguage; | ||
|
||
/** | ||
* CRM_Core_BAO_TranslateGetWrapper constructor. | ||
* | ||
* This wrapper replaces values with configured translated values, if any exist. | ||
* | ||
* @param array $translated | ||
*/ | ||
public function __construct($translated) { | ||
$this->fields = $translated['fields']; | ||
$this->translatedLanguage = $translated['language']; | ||
} | ||
|
||
/** | ||
* @inheritdoc | ||
*/ | ||
public function fromApiInput($apiRequest) { | ||
return $apiRequest; | ||
} | ||
|
||
/** | ||
* @inheritdoc | ||
*/ | ||
public function toApiOutput($apiRequest, $result) { | ||
foreach ($result as &$value) { | ||
if (!isset($value['id'], $this->fields[$value['id']])) { | ||
continue; | ||
} | ||
$toSet = array_intersect_key($this->fields[$value['id']], $value); | ||
$value = array_merge($value, $toSet); | ||
$value['actual_language'] = $this->translatedLanguage; | ||
} | ||
return $result; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really stumped me - I couldn't figure out what Biz Locale is - 'Business Locale' 'Bees Locale' 'Random Prefix Locale'?
I feel like maybe this is the ResolvedLocale?