Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make civi 2 nanoseconds faster #24169

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

Webtests haven't run in years, were physically removed a few years ago, and support in the mailutils was removed last year. No need to check in the classloader.

Before

Check for loading of webtest classes.

After

Don't check.

Technical Details

Comments

The diff on github looks weird, like I'm removing unrelated parts of two if clauses. It's not.

@civibot
Copy link

civibot bot commented Aug 6, 2022

(Standard links)

@civibot civibot bot added the master label Aug 6, 2022
@colemanw
Copy link
Member

colemanw commented Aug 6, 2022

Are you sure it's 2 nanoseconds? I think we need to spend a few days benchmarking and analyzing this so we can see how much time we're saving.

@demeritcowboy
Copy link
Contributor Author

Heehee. On my computer it's about 6 seconds so I just guestimated.
I need a new computer.

@seamuslee001 seamuslee001 merged commit d45c167 into civicrm:master Aug 7, 2022
@demeritcowboy demeritcowboy deleted the web-scale branch August 7, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants