dev/core/-/issues/3786 💩 Matching by External / Contact ID always matches contacts with ID < 10 for Participant importer and possibly others because return params is not an array

[agileware-justin]

Overview

Matching by External / Contact ID always matches contacts with ID < 10 for Participant importer and possibly others

This is due do an incorrectly replaced Error generation function in core commit 972906b (Merged for 5.51.0)

Steps to reproduce

1. Create a CSV with a Contact External ID or Contact ID, Event Title, Registration Status
2. Set up the import to match on Contact External ID or Contact ID
3. Map the other fields
4. Execute import

Error: Import will execute and create Participant records associated all with Contact ID: 1 or Contact ID: 2 (or another ID < ID:10). Not matching against the correct Contact ID.

Before

Cannot import Event Participants correctly. Participants are created but associated with the wrong Contact.

After

Can import Event Participants correctly. Participants are created and associated with the correct Contact.

Technical Details

Bug introduced due to recent refactor of import code,see core commit 972906b

Comments

This bug gets the 💩 icon because it took a very long time to track down and caused imports to fail, making a customer very unhappy 😬

Gitlab, https://lab.civicrm.org/dev/core/-/issues/3786

Agileware Ref: CIVICRM-2025

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton

[eileenmcnaughton]

We should target the rc for this one

[agileware-fj]

Just a note here that this PR and #24166 are neither redundant nor exclusive.

This change reverts breaking an interface that should have been frozen, the other removes an unnecessary operation on that interface – and also accounts for the breakage – where it's used in core.