-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update invoice template to be (mostly) previewable #24122
Conversation
(Standard links)
|
b285196
to
72f9134
Compare
I just added an example to add in the credit note part too |
5fd1aab
to
ddab941
Compare
ddab941
to
4791f4c
Compare
4791f4c
to
31e9d50
Compare
@demeritcowboy if you get a chance could you take a look at this - it is similar to the changes in the offline contribution template |
Ok I'll try to fit it in somewhere. |
As noted in the description the preview is missing some output, so ok. It's there in the pdf. But also the logo doesn't seem to display in the preview but it's ok in the pdf. Otherwise I just have the same UX complaints as before:
Resulting pdfs look ok. It ignores the tax display setting you have at contribute component settings, but it did that before. |
@demeritcowboy can you put those UI things in gitlab - I'm not really processing them right now but would like to come back to them |
oh for the logo there is another PR #24102 |
Overview
Switch line items in invoice template to previewable
This is part of standardising contribution templates so that
Before
$lineItem
array variable is used - this is assigned by the form & has an extra 'layer' to iterate through but is otherwise the sames as$lineItems
which theWorkflowTemplate
class makes available$taxTerm
is used - we are moving to tokens where possible so{domain.tax_term}
$dataArray
is used - we are moving to the$taxRateBreakdown
- which has a clearer name & more logical structureBelow output is from generating a pdf & almost no change should happen from this PR - the exception is the
dataArray
section just seemed wrong on the 'before' so I removed the second line in itFor refunded a credit note section is appended
After
The relevant preview part now works - with gaps which will later be filled with tokens from #24118
Technical Details
Once the main parts of the template are swapped we will push a template update & we can, in time, start to remove assignment complexity from the form layer
Comments