Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace cleanup in invoice template #24113

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 1, 2022

Overview

Whitespace cleanup in invoice template

https://github.com/civicrm/civicrm-core/pull/24113/files?w=1

Comments

whitespace only - but I think it exposes an extraneous 'if' at the end which I'll dig into after. Note this could be a regression as the sql is not yet regenerated

@civibot
Copy link

civibot bot commented Aug 1, 2022

(Standard links)

@civibot civibot bot added the master label Aug 1, 2022
@eileenmcnaughton
Copy link
Contributor Author

OK - I was wrong about tests not picking up - looks like I need to edit in tests too - still can't see where that if opens

@eileenmcnaughton
Copy link
Contributor Author

@eileenmcnaughton
Copy link
Contributor Author

eileenmcnaughton commented Aug 2, 2022

@demeritcowboy - this is hopefully straight forward.... - it seems ideally we would follow up with fixes to make it

<td style="text-align:right"> etc

@seamuslee001
Copy link
Contributor

Reviewing this with the ?w=1 mode everything looks right

@seamuslee001 seamuslee001 merged commit d20d718 into civicrm:master Aug 2, 2022
@seamuslee001 seamuslee001 deleted the inv_close branch August 2, 2022 04:13
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants