Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade for contribution offline receipt #24101

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 31, 2022

Overview

Add upgrade for contribution offline receipt

Before

There are a few updated in the receipts that we have not push-upgraded but the updates to the contribution offline receipts are now fairly material with new preferred smarty variables

$lineItems
$taxRateBreakdown
$isShowTax

After

Default message templates updates, users will see message to update their templates

Technical Details

I've added a little bit over at https://docs.civicrm.org/user/en/latest/email/message-templates/#variables-and-tokens-in-workflow-message-templates - I could add it to the upgrade message maybe

Comments

@demeritcowboy

@civibot
Copy link

civibot bot commented Jul 31, 2022

(Standard links)

@civibot civibot bot added the master label Jul 31, 2022
@demeritcowboy
Copy link
Contributor

Putting merge-ready since it's always difficult to pick the right time. It might be nice to fix the table if we're going to ask people to update it.

@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Jul 31, 2022
@eileenmcnaughton
Copy link
Contributor Author

I'm merging this based on the merge-ready. I thought about not merging it as there is a minor regression to fix on the lineItem.title not always having the full detail - but on testing another patch I found that we really want to add event_online_registration to the list as what we are currently doing is worse for the user than forcing an update (we are telling them to update the formatting of dates without doing it for them, where possible) - so I want to add that in. I'll fix the minor-regression in the rc if not fixed before it is cut

@eileenmcnaughton eileenmcnaughton merged commit db8a551 into civicrm:master Aug 3, 2022
@eileenmcnaughton eileenmcnaughton deleted the msg branch August 3, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants