Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.1] Permit single quotes within html attributes #24083

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

seamuslee001
Copy link
Contributor

Overview

In PHP8.1 the default flags for htmlentities changed

8.1.0	flags changed from ENT_COMPAT to ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401.

This meant that now ' was getting escaped in php8.1 when it wasn't before, this just restores that back for this specific thing

Before

Test fails because of the change in Flags

After

Tests pass on php8.1

ping @eileenmcnaughton @totten @colemanw @demeritcowboy

@civibot
Copy link

civibot bot commented Jul 28, 2022

(Standard links)

@civibot civibot bot added the master label Jul 28, 2022
@demeritcowboy demeritcowboy merged commit 5c84a37 into civicrm:master Jul 30, 2022
@eileenmcnaughton eileenmcnaughton deleted the php81_page_singlequotes branch July 31, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants