Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case custom field with clickable contact reference #24072

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

vitius1
Copy link
Contributor

@vitius1 vitius1 commented Jul 28, 2022

In manage case if we have custom field as contact reference we cant click on this contact. I used same condition as CRM/Custom/Page/CustomDataView.tpl, which create clickable contact reference.

In manage case if we have custom field as contact reference we cant click on this contact. I used same condition as CRM/Custom/Page/CustomDataView.tpl, which create clickable contact reference.
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Jul 28, 2022

(Standard links)

@civibot civibot bot added the master label Jul 28, 2022
@vitius1 vitius1 changed the title CustomDataView.tpl with clickable contact reference Case custom field with clickable contact reference Jul 28, 2022
@demeritcowboy
Copy link
Contributor

Thanks for the patch.
I guess we allow smarty to run in insecure mode outside of tests since normally implode wouldn't be allowed by smarty, but as you've noted it's already in the other file and it does seem to run ok.

jenkins test this please

@demeritcowboy demeritcowboy merged commit c43d926 into civicrm:master Jul 28, 2022
@demeritcowboy
Copy link
Contributor

@vitius1 can you make another PR to add yourself into this file https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml for release notes credit?

@vitius1 vitius1 deleted the patch-1 branch July 28, 2022 20:09
@vitius1
Copy link
Contributor Author

vitius1 commented Jul 28, 2022

@vitius1 can you make another PR to add yourself into this file https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml for release notes credit?

Here is the PR: #24078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants