Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add in Post Upgrade message about %A format change #24070

Closed
wants to merge 1 commit into from
Closed

[REF] Add in Post Upgrade message about %A format change #24070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CRM/Upgrade/Incremental/php/FiveFiftyThree.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@
*/
class CRM_Upgrade_Incremental_php_FiveFiftyThree extends CRM_Upgrade_Incremental_Base {

public function setPostUpgradeMessage(&$postUpgradeMessage, $rev) {
if ($rev === '5.53.alpha1') {
$postUpgradeMessage .= '<br/>' . ts("WARNING: CiviCRM has changed our the date format variable %1 is outputted when using CRM_Core_Date::customFormat / crmDate. Please review your <a href='%2' target='_blank'>Date Format</a> settings and your <a href='%3' target='_blank'>system message templates</a> for usage of the %1 variable", [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CiviCRM has changed our the date format variable

our => how ?

Also CRM_Utils_Date not Core_Date. But I think I'll put up an alternate PR because while a message is still good, it seems safe to just go ahead and have the upgrade replace %A with %P in any of the settings on the admin page, and for message templates it could tell you which ones have the string %A in them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tricky part is that if it is date_format|%A is fine but not crmDate|%A

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the settings on the admin page they don't have smarty code in them and are purely format strings, so I think it's safe to just replace there. In message templates yes there might be all kinds of whack.

1 => '%A',
2 => CRM_Utils_System::url('civicrm/admin/setting/date', ['reset' => 1], TRUE),
3 => CRM_Utils_System::url('civicrm/admin/messageTemplates', ['reset' => 1, 'selectedChild' => 'workflow'], TRUE),
]);
}
}

/**
* Upgrade step; adds tasks including 'runSql'.
*
Expand Down