Remove legacy apiquery call from isContactInGroup
#24062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Jul 27, 2022
| return FALSE; | ||
| public static function isContactInGroup(int $contactID, int $groupID) { | ||
| return (bool) Contact::get(FALSE) | ||
| ->addWhere('id', '=', $contactID) |
There was a problem hiding this comment.
Suggested change
| ->addWhere('id', '=', $contactID) | |
| ->addWhere('id', '=', $contactID) | |
| ->selectRowCount() |
There was a problem hiding this comment.
@eileenmcnaughton this PR looks good overall, but if all we're doing is counting then this results in more efficient SQL.
4f49bd5 to
92b99d9
Compare
|
@colemanw I've updated per your suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove legacy
apiquerycall fromisContactInGroupBefore
Legacy function call to determine if contact is in a group
After
Api call
Technical Details
This is only called from one place in core & one test. I figured I'd clean it up while the test still calls if for reviewer friendliness. So, it's only soft-deprecated at the main function level
Comments
Getting rid of calls to
apiQueryis a back-burner goal