Update references to 'workflow' (from old 'valueName' parameter)

[eileenmcnaughton]

Overview

Update references to 'workflow' (from old 'valueName' parameter)

Before

We have deprecated valueName and the docs are updated to use workflow instead. There is handling to ensure both are passed to alterMailParams and we have updated some places to pass workflow, safe in the knowledge that alterMailParams will get both - but confusingly lots of places still pass valueName

After

valueName is 'almost' gone. There is still the sync code and references in unit tests designed to check what alterMailParams gets.

The api v3 code is a bit tricksy. Where we end up is that

• the new (workflow, the old valueName and the attempt to have a prettier variable for the api option_value_name) are all accepted
• workflow is the promoted param

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw are you OK to merge this - it has that excruciatingly thorough level of test cover that we reserve for hypothetically-possible edge cases so there is no impact on extension writers etc

[colemanw]

Yep, looks good.