dev/core#3050 - (Alternate) Fix crash removing an entry from a batch

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/3050

Alternate to #23957

Before

1. Contributions - Accounting Batches - New batch
2. Add one of the contributions to the batch.
3. Using the "Remove" link on the far right of the row, remove the entry you just added.
4. Crash

After

Ok

Technical Details

The backend was refactored in #21213 but it doesn't work here from the ajax call.

Comments

The test from the other PR won't work here. Not sure what to do for a test since it would mostly just be a test of calling api4.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Ohh well done - yeah I was definitely in quote hell

[eileenmcnaughton]

@demeritcowboy I tested this & it works so I'm going to merge it. There is a gap, however, in that I am pretty sure the permissions on the api are not well tuned and I think it falls back on administer CiviCRM but probably should be 'edit all manual batches' / 'edit own manual batches'

However - it's not working at all without this PR so the case to merge this in advance of any permission fix kinda makes itself :-)

[demeritcowboy]

Thanks!