(dev/core#3732) Show billing address on Edit contribution screen as well

[yashodha]

Overview

We currently show billing address on View Contribution screen. We should show billing address on Edit Contribution screen as well for consistency.

Before

Billing address is shown only on View contribution screen

After

Billing address is shown on both View contribution and Edit contribution screens

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Overall this PR looks good but some notes:

• We don't use CRM_Utils_Array::value() anymore if possible (use php 7 ??), but also this is inside an if where it already checks if the value exists, so it's not necessary.
• You need to $this->assign('billing_address') outside the if so that it always has a value, since otherwise the tpl {if $billing_address} will give a warning. Maybe just before the if add $this->assign('billing_address', NULL); so it will be assigned something.

[demeritcowboy]

@yashodha this just needs a minor tweak ^^^^ and then would be mergeable

[yashodha]

@demeritcowboy I have incorporated the feedback for the PR.

[yashodha]

@demeritcowboy thanks!