Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] dev/core#3676 Add in html2text/html2text to replace usage of roundcube's version we have in packages #23971

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

seamuslee001
Copy link
Contributor

Overview

This replaces the usage of roundcube's html2text with the html2text/html2text package as suggested by @MegaphoneJon on the lab ticket

Before

Roundcube's html2text used and an old version at that

After

html2text/html2text package used with a patch to support php8.1

ping @eileenmcnaughton @demeritcowboy @MegaphoneJon

@civibot
Copy link

civibot bot commented Jul 8, 2022

(Standard links)

@civibot civibot bot added the master label Jul 8, 2022
trim($text),
trim($output),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is just correcting the order of the function parameters the expected output should be first then the actual recorded output

@eileenmcnaughton
Copy link
Contributor

image

@seamuslee001
Copy link
Contributor Author

ok I think i have those failures fixed now

@demeritcowboy
Copy link
Contributor

For what it's worth universe doesn't show anyone else using the packages one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants