Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF - Remove unneeded return from private fn, add comments #23967

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 7, 2022

Overview

Simple code cleanup & add comments.

@civibot
Copy link

civibot bot commented Jul 7, 2022

(Standard links)

@civibot civibot bot added the master label Jul 7, 2022
@colemanw colemanw marked this pull request as ready for review July 7, 2022 22:20
@eileenmcnaughton
Copy link
Contributor

This seems fine but we can also remove another return in the same function

image

@colemanw
Copy link
Member Author

colemanw commented Jul 8, 2022

@eileenmcnaughton actually that return is not from the same function, it's from a nested callback to addSettingsFactory

@eileenmcnaughton
Copy link
Contributor

Oh yuck - a nested call back - OK merging

@eileenmcnaughton eileenmcnaughton merged commit c98e5bd into civicrm:master Jul 8, 2022
@colemanw colemanw deleted the angularCleanup branch November 8, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants