Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.1] Fix deprecations where by calling trait static function… #23960

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

seamuslee001
Copy link
Contributor

…s when not from a class that implements the trait is deprecated

Overview

This aims to fix deprecations like the following

PHP Deprecated:  Calling static trait method Civi\Api4\Generic\Traits\ArrayQueryActionTrait::filterCompare is deprecated, it should only be called on a class using the trait in /home/seamus/buildkit/build/dtest/web/sites/all/modules/civi                                                                                crm/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php on line 306

Before

Deprecations generated running unit tests locally

After

Less deprecations generated

ping @totten @eileenmcnaughton @demeritcowboy

…s when not from a class that implements the trait is deprecated
@civibot
Copy link

civibot bot commented Jul 7, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor

These all look good to me & I'm confident tests would fail if there is any problem in them

@totten
Copy link
Member

totten commented Jul 7, 2022

On the CRM/Core/Resource** stuff -- there should be a lot of coverge for that; if it passes, then it's ready to merge.

I'll leave it to @colemanw to comment on the impact of adding ArrayQueryActionTrait to AbstractRunAction.

@seamuslee001 seamuslee001 merged commit 442174f into civicrm:master Jul 7, 2022
@seamuslee001 seamuslee001 deleted the fix_static_calling_trait branch July 7, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants