Afform - Allow picking icon for tab, add CrmUiIconPicker widget #23919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Allows afforms placed as a contact summary tab to specify an icon. It also switches Afforms's hook_civicrm_tabset to use the API, which ensures virtual forms get picked up. Adds the new icon for CiviGrant as an example.
|
Looks good - that's nice having the popup icon picker rather than requiring you to know the icon name.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When embedding an afform in the contact summary tab, this allows you to pick an icon.
This also adds the correct icon to the Grants tab for the CiviGrant extension.
Also see: https://lab.civicrm.org/extensions/certifications/-/issues/9
Before
Icon could be customized with the Contact Layout Editor, which works for local customizations but not for packaged Afforms.
After
Icon can be specified in Afform GUI, and in packaged Afform json.
Technical Details
Since this is needed in several places, this adds a general purpose crmUiIconPicker widget to crmUi.
It also switches Afforms's hook_civicrm_tabset to use the API, which ensures virtual forms get picked up.